Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed a duplicate DeniedSigner from microsoft-recommended-driver-block-rules #11979

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Removed a duplicate DeniedSigner from microsoft-recommended-driver-block-rules #11979

merged 4 commits into from
Jan 7, 2025

Conversation

HotCakeX
Copy link
Contributor

The following DeniedSigner is mentioned twice which isn't supposed to happen.

<DeniedSigner SignerId="ID_SIGNER_ECSIODRV" />

Only one is enough, there is only one signer referencing it

 <Signer ID="ID_SIGNER_ECSIODRV" Name="GlobalSign Primary Object Publishing CA">
      <CertRoot Type="TBS" Value="879269F3F467A6D59641960A62FE9CB419355FF6" />
      <CertPublisher Value="ELITEGROUP COMPUTER SYSTEMS CO" />
      <FileAttribRef RuleID="ID_FILEATTRIB_ECSIODRV" />
    </Signer>

So I just removed the extra DenierSigner, everything checks out now and is valid according to the CI Schema.

@github-actions github-actions bot added the Tier3 label Dec 26, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit ffa6237:

✅ Validation status: passed

File Status Preview URL Details
windows/security/application-security/application-control/app-control-for-business/design/microsoft-recommended-driver-block-rules.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@aczechowski aczechowski requested a review from jgeurten December 26, 2024 19:40
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 17d7fc2:

✅ Validation status: passed

File Status Preview URL Details
windows/security/application-security/application-control/app-control-for-business/design/microsoft-recommended-driver-block-rules.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 4b266d1:

✅ Validation status: passed

File Status Preview URL Details
windows/security/application-security/application-control/app-control-for-business/design/microsoft-recommended-driver-block-rules.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@HotCakeX HotCakeX changed the title Removed duplicate DenierSigner from microsoft-recommended-driver-block-rules Removed a duplicate DeniedSigner from microsoft-recommended-driver-block-rules Jan 6, 2025
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 8fa50e8:

✅ Validation status: passed

File Status Preview URL Details
windows/security/application-security/application-control/app-control-for-business/design/microsoft-recommended-driver-block-rules.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@aczechowski
Copy link
Member

Jordan approved, so I'm merging. Thanks @HotCakeX for the edit! :)

@aczechowski aczechowski merged commit 2421301 into MicrosoftDocs:public Jan 7, 2025
6 checks passed
@HotCakeX
Copy link
Contributor Author

HotCakeX commented Jan 8, 2025

@aczechowski No problem, thanks for merging it ^^

@HotCakeX HotCakeX deleted the patch-1 branch January 8, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgeurten jgeurten jgeurten approved these changes

Assignees
No one assigned
Labels
Tier3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HotCakeX @aczechowski @jgeurten